-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix get_mesh after xugrid update #848
Conversation
I added a super simple test and also tested with the more complex hydromt_delft3dfm plugin and seems it should now be solved. Can you check and review @Tjalling-dejong ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but can you remove the commented code?
Good one! Was late Friday evening when I finished... Can you review again ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Issue addressed
None defined: MeshModel.get_mesh method returns error after xugrid update to 0.9.0
Explanation
Xugrid does not support well having data variables that are not part of the grid definition and their new check grid is too restrictive on optional ugrid dims that are not part of the data variable dims.
Checklist
main